Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14 #71

Merged
merged 3 commits into from
Feb 12, 2025
Merged

#14 #71

merged 3 commits into from
Feb 12, 2025

Conversation

Meastro85
Copy link
Collaborator

@Meastro85 Meastro85 commented Feb 10, 2025

🤍🩵💜MERGEREQUEST💜🩵🤍

📘Table of Contents

  1. 📘Table of Contents
  2. 🖖Introduction
  3. 📎Definition of done Merge Request checklist.

🖖Introduction

This is a Merge Request that is in need of your attention. The person who created this request is the assignee.

📎Definition of done Merge Request checklist.

  • Tests written (1 positive and 1 negative scenario if possible).

Code architecture

  • Separate services (SRP).
  • Divide functions into functions with low complexity

Code Quality

  • Everything runs.
  • Comments and unused code gone.
  • Correct error handling.

@Meastro85 Meastro85 self-assigned this Feb 10, 2025
@VW03 VW03 merged commit 1be9ba3 into main Feb 12, 2025
6 checks passed
@Meastro85 Meastro85 deleted the #14 branch February 12, 2025 19:21
@EliasDeHondt EliasDeHondt added the Closed The issue or task has been completed or resolved. label Feb 13, 2025
@EliasDeHondt EliasDeHondt added this to the v1.0.0 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed The issue or task has been completed or resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants